-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builder): followSymlinks
option to allow for symlinks
#6368
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6368 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 79 79
Lines 2692 2692
Branches 696 696
=======================================
Hits 2575 2575
Misses 101 101
Partials 16 16
Continue to review full report at Codecov.
|
@SnirShechter Thanks for this pr. Would it maybe be possible to combine the tests with an existing fixture? Adding it to Also note that it seems you are using a different emailaddress in your local git config then for github. If you want you can either add that other emailaddress to your github account (Settings -> Emails) or correct the emailaddress & do a force-push (old commits will still be accessible though). |
Hey, sorry for the really late reply. I'm on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only thing I was thinking about is to maybe make it possible for a user to set any glob option, but I think we probably shouldnt do that as changing a setting like absolute
or realpath
could result in unexpected behaviour in nuxt.
It is something worth thinking of, but basically followSymlinks is (through my point of view) much more than a simple glob setting, since it allows separation of pages in different folders. For me and my company, this means that we can integrate one project into another, when built right. Thanks for the approval 👍 |
Types of changes
Description
This PR adds a build.followSymlinks boolean(default: false), and passes it to the builder's glob function inside resolveFiles().
This allows for following symlinks inside layouts/middleware/pages/store, thus including them in the app.
Checklist: