-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-app): layout in error.vue not work for Vue.extend component #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkdo
changed the title
fix: layout in error.vue not work for Vue.extend component
fix(vue-app): layout in error.vue not work for Vue.extend component
Nov 3, 2019
aldarund
approved these changes
Nov 4, 2019
atinux
approved these changes
Nov 5, 2019
kevinmarrec
approved these changes
Nov 5, 2019
Codecov Report
@@ Coverage Diff @@
## dev #6650 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 78 78
Lines 2713 2713
Branches 702 702
=======================================
Hits 2599 2599
Misses 99 99
Partials 15 15
Continue to review full report at Codecov.
|
This was referenced Nov 26, 2019
Merged
This was referenced Mar 20, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fix #6651
Reported from Discord from @aldarund , when component is from
Vue.extend
, thelayout
onerror.vue
doesn't, this is becauselayout
iscomponent.options.layout
but notcomponent.layout
.Checklist: