refactor(server): only append not empty allowed sources to csp #6771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6771 +/- ##
=======================================
Coverage 64.82% 64.82%
=======================================
Files 78 78
Lines 2718 2718
Branches 706 706
=======================================
Hits 1762 1762
Misses 729 729
Partials 227 227
Continue to review full report at Codecov.
|
atinux
approved these changes
Dec 16, 2019
pi0
changed the title
Merged
This was referenced Mar 20, 2020
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip string concatation and continue other logic if allowedSources is empty array