Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: serverMiddleware HMR improvements #6896

Merged
merged 2 commits into from
Jan 20, 2020
Merged

chore: serverMiddleware HMR improvements #6896

merged 2 commits into from
Jan 20, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 20, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Followed by #6881:

  • Improve route fallback strategy. Always preserve previous route if no new one provided
  • Fix support for express apps as middleware. (connect behaviour is undocumented so i used a simpler approach)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested a review from atinux January 20, 2020 18:10
@codecov-io
Copy link

Codecov Report

Merging #6896 into dev will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6896      +/-   ##
==========================================
- Coverage   62.62%   62.61%   -0.02%     
==========================================
  Files          82       82              
  Lines        3291     3295       +4     
  Branches      894      896       +2     
==========================================
+ Hits         2061     2063       +2     
- Misses        988      989       +1     
- Partials      242      243       +1
Flag Coverage Δ
#e2e ?
#unit ?
#unittests 62.61% <66.66%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/server/src/server.js 83.89% <66.66%> (-0.25%) ⬇️
packages/utils/src/route.js 96.55% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a375a6c...05d3d13. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants