Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-renderer): support crossorigin attr in ssr script and preload tags #6950

Merged
merged 4 commits into from
Feb 24, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Feb 8, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolve #6635
Resolve #6634

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and a team February 8, 2020 21:33
@clarkdo
Copy link
Member Author

clarkdo commented Feb 8, 2020

Vue PR vuejs/vue#11094

@codecov-io
Copy link

codecov-io commented Feb 8, 2020

Codecov Report

Merging #6950 into dev will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6950      +/-   ##
==========================================
- Coverage   62.66%   62.63%   -0.04%     
==========================================
  Files          82       82              
  Lines        3311     3313       +2     
  Branches      898      899       +1     
==========================================
  Hits         2075     2075              
- Misses        993      994       +1     
- Partials      243      244       +1
Flag Coverage Δ
#unittests 62.63% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c98a9...17957f3. Read the comment docs.

@pi0 pi0 changed the title feat: add crossorigin for normal ssr feat(vue-renderer): add crossorigin for normal ssr Feb 24, 2020
@pi0 pi0 changed the title feat(vue-renderer): add crossorigin for normal ssr feat(vue-renderer): add crossorigin to preload tags Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxt.config.js build.crossorigin with nuxt generate not working
5 participants