Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct deprecated hooks #7002

Merged
merged 5 commits into from
Feb 25, 2020
Merged

fix: correct deprecated hooks #7002

merged 5 commits into from
Feb 25, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 25, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Closes #6968 Fixes #6959

Initial typo: #4722

render:context

render:routeContext

vue-renderer:ssr:context

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

packages/core/test/nuxt.test.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #7002 into dev will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7002   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files          82       82           
  Lines        3322     3322           
  Branches      901      901           
=======================================
  Hits         2075     2075           
  Misses       1001     1001           
  Partials      246      246
Flag Coverage Δ
#unittests 62.46% <0%> (ø) ⬆️
Impacted Files Coverage Δ
packages/core/src/nuxt.js 93.18% <ø> (ø) ⬆️
packages/vue-renderer/src/renderers/ssr.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084a1ca...27b1eb8. Read the comment docs.

@pi0 pi0 requested a review from clarkdo February 25, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renderer hooks don't get called, wrong deprecation warnings
4 participants