Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): avoid warning with legacy postcss.config.js #7098

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

mercs600
Copy link

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #7062 . Just removed outdated postcss.config.js and setup postcss plugins in nuxt.config.js.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Mar 17, 2020

Codecov Report

Merging #7098 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7098   +/-   ##
=======================================
  Coverage   62.69%   62.69%           
=======================================
  Files          84       84           
  Lines        3394     3394           
  Branches      926      926           
=======================================
  Hits         2128     2128           
  Misses       1018     1018           
  Partials      248      248
Flag Coverage Δ
#unittests 62.69% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e7397...1780f27. Read the comment docs.

@manniL
Copy link
Member

manniL commented Mar 17, 2020

Thank you! ☺️

I guess an update with https://github.com/nuxt-community/nuxt-tailwindcss would be even better 😋

@mercs600
Copy link
Author

@manniL So you want to change this example to '@nuxtjs/tailwindcss' module ? I can do it, but is it worthy ? I mean setup the module is nothing special, but this simple configuration shows to developers how they can do it by hand - it gives more values. What do you think ?

@pi0
Copy link
Member

pi0 commented Mar 18, 2020

Hi @mercs600 thanks for PR ❤️ I was also going to comment the same as @manniL. Let's wait for @atinux opinion on this :)

@pi0 pi0 requested a review from atinux March 18, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tailwindcss-purgecss example is not more up to date
6 participants