Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): join with os native sep in resolver #7131

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 25, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

After investigation for the root cause of #7097, it seems node CJS cache entry ids are exactly how they are being required and something like require('c:\\foo\\bar/index.js) is also valid but HMR watcher get os native path (c:\\foo\\bar\\index.js). This issue was not discovered until yet because node.js for windows supports mixed path separators.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 requested review from clarkdo, atinux and a team March 25, 2020 20:00
clarkdo
clarkdo previously approved these changes Mar 25, 2020
@pi0 pi0 changed the title fix(core): join with os native sep fix(core): join with os native sep in resolver Mar 27, 2020
@codecov-io
Copy link

Codecov Report

Merging #7131 into dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #7131      +/-   ##
==========================================
+ Coverage   62.75%   62.76%   +0.01%     
==========================================
  Files          84       84              
  Lines        3399     3400       +1     
  Branches      928      928              
==========================================
+ Hits         2133     2134       +1     
  Misses       1018     1018              
  Partials      248      248              
Flag Coverage Δ
#unittests 62.76% <100.00%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/core/src/resolver.js 97.33% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b5bf5...cd0a04e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants