-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): join with os native sep in resolver #7131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkdo
previously approved these changes
Mar 25, 2020
pi0
changed the title
fix(core): join with os native sep
fix(core): join with os native sep in resolver
Mar 27, 2020
Codecov Report
@@ Coverage Diff @@
## dev #7131 +/- ##
==========================================
+ Coverage 62.75% 62.76% +0.01%
==========================================
Files 84 84
Lines 3399 3400 +1
Branches 928 928
==========================================
+ Hits 2133 2134 +1
Misses 1018 1018
Partials 248 248
Continue to review full report at Codecov.
|
pi0
added a commit
that referenced
this pull request
Mar 31, 2020
Merged
This was referenced Apr 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
After investigation for the root cause of #7097, it seems node CJS cache entry ids are exactly how they are being required and something like
require('c:\\foo\\bar/index.js)
is also valid but HMR watcher get os native path (c:\\foo\\bar\\index.js
). This issue was not discovered until yet because node.js for windows supports mixed path separators.Checklist: