feat: show build error #45
Conversation
app/index.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| import Vue from 'vue' | |||
| import App from './app.vue' | |||
|
|
|||
| Vue.config.devtools = true | |||
There was a problem hiding this comment.
We dont, but had to test/debug the vue-app and with yarn link I still had to build the project to test it with Nuxt. And I thought, why not leave it on, its just a development tool anyway.
There was a problem hiding this comment.
It triggers an extra dev tool for end-users during loading. I think loading it may consume little CPU as it has to inspect events, ...
There was a problem hiding this comment.
If you are afraid that enabling it could cause problems I have no problem with removing this
|
I was thinking this morning that maybe we should add a message that it might be possible that the Nuxt server needs to be restarted manually? E.g. if you add a wrong plugin then thats the case |
|
Good idea about restart suggestion. |
fix: add missing files
|
After the latest commit the page now looks like this, let me know what you think:
|
| } | ||
|
|
||
| clearStates (hasErrors) { | ||
| this.status = [] |
There was a problem hiding this comment.
@pi0 oops, made a typo here! should be states not status
There was a problem hiding this comment.
Would you please make direct commit to master?
There was a problem hiding this comment.
this message was to ping you asap in case you were already releasing ;)
There was a problem hiding this comment.
I won't release without proper testing ;)
This adds support for an error state which prints a stacktrace on the loading screen.
See the corresponding nuxt pr which uses this so build errors in dev mode are shown on the loading screen.