From 1392aa3acb3d6b9e042077caad7a3edba3065e08 Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Fri, 5 Feb 2021 15:50:56 +0800 Subject: [PATCH] Add code review checklist for PRs (PR #12037) Co-authored-by: Leonard de Ruijter --- .github/PULL_REQUEST_TEMPLATE.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c1a874b202e..21c99dab42d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ Please also note that the NVDA project has a Citizen and Contributor Code of Con ### Description of how this pull request fixes the issue: -### Testing performed: +### Testing strategy: ### Known issues with pull request: @@ -17,3 +17,16 @@ Please also note that the NVDA project has a Citizen and Contributor Code of Con Section: New features, Changes, Bug fixes +### Code Review Checklist: + +This checklist is a reminder of things commonly forgotten in a new PR. +Please do a self-review to check these items. +Reviewers will not approve the PR until these are met. + +- [ ] Pull Request description is up to date. +- [ ] Unit tests. +- [ ] System (end to end) tests. +- [ ] Manual tests. +- [ ] User Documentation. +- [ ] Change log entry. +- [ ] Context sensitive help for GUI changes.