From 5fbe05d4ddb28a255ec10dde5372f2f3b34be6e3 Mon Sep 17 00:00:00 2001 From: Reef Turner Date: Wed, 17 Mar 2021 18:56:59 +0800 Subject: [PATCH] Enable cancellable speech by default (PR #11266) First introduced with "Cancellable speech #10885" Several issues fixed with "Fix several issues in speech manager #11245" --- source/gui/settingsDialogs.py | 2 +- source/speech/manager.py | 4 ++-- user_docs/en/changes.t2t | 3 +++ 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/source/gui/settingsDialogs.py b/source/gui/settingsDialogs.py index 4b0a9dc40fa..df5ce3dd8e6 100644 --- a/source/gui/settingsDialogs.py +++ b/source/gui/settingsDialogs.py @@ -2648,7 +2648,7 @@ def __init__(self, parent): expiredFocusSpeechChoices = [ # Translators: Label for the 'Cancel speech for expired &focus events' combobox # in the Advanced settings panel. - _("Default (No)"), + _("Default (Yes)"), # Translators: Label for the 'Cancel speech for expired &focus events' combobox # in the Advanced settings panel. _("Yes"), diff --git a/source/speech/manager.py b/source/speech/manager.py index efb97c7af53..6e4fcd7c519 100644 --- a/source/speech/manager.py +++ b/source/speech/manager.py @@ -34,8 +34,8 @@ def _shouldCancelExpiredFocusEvents(): - # 0: default (no), 1: yes, 2: no - return config.conf["featureFlag"]["cancelExpiredFocusSpeech"] == 1 + # 0: default (yes), 1: yes, 2: no + return config.conf["featureFlag"]["cancelExpiredFocusSpeech"] != 2 def _shouldDoSpeechManagerLogging(): diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t index cd0f48e3f8b..9af95ba8e2e 100644 --- a/user_docs/en/changes.t2t +++ b/user_docs/en/changes.t2t @@ -16,6 +16,9 @@ What's New in NVDA - Added more mathematical symbols to the symbols dictionary. (#11467) - The user guide, changes file, and key commands listing now have a refreshed appearance. (#12027) - "Unsupported" now reported when attempting to toggle screen layout in applications that do not support it, such as Microsoft Word. (#7297) +- 'Attempt to cancel speech for expired focus events' option in the advanced settings panel now enabled by default. + - This behaviour can be disabled by default with by setting this option to "No". + - Web applications (E.G. Gmail) no longer speak outdated information when moving focus rapidly. (#10885) == Bug Fixes ==