Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Request] State Rust version requirements (1.63) explicitly #10

Closed
koachan opened this issue Sep 19, 2022 · 3 comments
Closed

[Docs Request] State Rust version requirements (1.63) explicitly #10

koachan opened this issue Sep 19, 2022 · 3 comments

Comments

@koachan
Copy link

koachan commented Sep 19, 2022

Hello, I'm having errors when trying to build it on my machine, using Rust 1.62.1 on Gentoo.

error[E0658]: use of unstable library feature 'scoped_threads'
  --> src/main.rs:36:5
   |
36 |     std::thread::scope(|s| {
   |     ^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #93203 <https://github.com/rust-lang/rust/issues/93203> for more information

error[E0658]: use of unstable library feature 'scoped_threads'
  --> src/main.rs:38:11
   |
38 |         s.spawn(|| {
   |           ^^^^^
   |
   = note: see issue #93203 <https://github.com/rust-lang/rust/issues/93203> for more information

error[E0658]: use of unstable library feature 'scoped_threads'
  --> src/main.rs:50:11
   |
50 |         s.spawn(|| {
   |           ^^^^^
   |
   = note: see issue #93203 <https://github.com/rust-lang/rust/issues/93203> for more information

error[E0658]: use of unstable library feature 'scoped_threads'
  --> src/main.rs:68:10
   |
68 |         .join()
   |          ^^^^
   |
   = note: see issue #93203 <https://github.com/rust-lang/rust/issues/93203> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `core-to-core-latency` due to 4 previous errors

Seems like it uses a feature that only starts becoming available in Rust 1.63, so I suppose this could be stated explicitly in the readme file?

@nviennot
Copy link
Owner

Let me rewrite the code without using such feature

@nviennot
Copy link
Owner

Okay, I've pushed a new version that only requires Rust 1.57. I've added a badge on the README

@koachan
Copy link
Author

koachan commented Sep 19, 2022

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants