feat: updated to current link format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
atm there is no space after * etc |
mrossinek
reviewed
Dec 14, 2021
3 tasks
max397574
changed the title
mrossinek
reviewed
Dec 14, 2021
| .. inserted_file | ||
| .. entry.display:gsub("^(%W+)%s+.+", "%1") | ||
| .. entry.display:gsub("^(%W+)%s+.+", "%1 ") | ||
| .. entry.ordinal:gsub("[%*#%|_]", "\\%1") |
There was a problem hiding this comment.
If I'm understanding this regex correctly this is checking for the various symbols that need escaping. If that is true, then we need to add all detached modifiers which can be linked against, right @vhyrro?
There was a problem hiding this comment.
Honestly I don't think we need to escape custom symbols anymore, only } symbols in the case of {this} and ] symbols in the case of [this].
max397574
commented
Dec 23, 2021
| @@ -76,8 +79,6 @@ local function generate_links() | |||
| return | |||
| end | |||
|
|
|||
| vim.fn.bufload(full_path_file) | |||
There was a problem hiding this comment.
replaced with readfile because it's much faster
| if vim.api.nvim_get_current_buf() ~= bufnr then | ||
| vim.cmd('bunload! ' .. bufnr) | ||
| end | ||
|
|
There was a problem hiding this comment.
no longer needed because of the readfile
| file = file:gsub(".norg", "") | ||
| else | ||
| lines = vim.api.nvim_buf_get_lines(bufnr, 0, -1, true) |
There was a problem hiding this comment.
use readfile instead of buf_get_lines
vhyrro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.