New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Token #3

Open

schrc3b6 opened this issue Aug 1, 2024 · 0 comments

schrc3b6 commented Aug 1, 2024

Hi,

I have recently started to use orgmode, great plugin!

However, I'm currently missing image support (org-toggle-inline-images) and external link support (https://orgmode.org/manual/External-Links.html).

I started to look, how to add integration for org files to https://github.com/3rd/image.nvim.
They use treesitter to query all links. However, I noticed that the org grammar has no image symbol, and you use regex matching for almost all expressions (https://github.com/nvim-orgmode/orgmode/blob/de02a0cfbe3484accb73025b6dd71b2cc4ae3eff/lua/orgmode/files/file.lua#L721).

My Questions:

Is there a reason for not introducing an image symbol to the treesitter grammar?
Would that help in the hyperlink refactor (feat: Opening hyperlinks externally orgmode#578) ?
Would you accept a PR for this and are you interested in inline image support for orgmode via image.nvim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment