Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[readme] reorganize “deeper shell integration” instructions #1569

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[readme] reorganize “deeper shell integration” instructions #1569

merged 1 commit into from
Dec 5, 2023

Conversation

benwiley4000
Copy link
Contributor

No description provided.

@benwiley4000
Copy link
Contributor Author

benwiley4000 commented Jun 29, 2017 •
edited
Loading

I don't understand how or why, but this broke a test?? :O https://travis-ci.org/creationix/nvm/jobs/248482210

@ljharb
Copy link
Member

ljharb commented Jun 29, 2017

You need to run npm run doctoc to update the table of contents.

ljharb
ljharb requested changes Jun 29, 2017
View reviewed changes
README.md Outdated
```bash
# place this after nvm initialization!
load-nvmrc() {
# same definition as zsh-hook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd prefer to either repeat the definition, or (better), have it in one place, and then only have the different sections for zsh and bash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll get on it.

@benwiley4000 benwiley4000 force-pushed the patch-1 branch 2 times, most recently from 785ae8c to 202d8a5 Compare June 30, 2017 01:57
@benwiley4000
Copy link
Contributor Author

I organized the script examples as you suggested, and updated some of the language to be more specific, so let me know if that's ok.

@benwiley4000
Copy link
Contributor Author

@ljharb anything blocking this merge?

@ljharb ljharb changed the title Alternative plain bash instructions for zsh hook [readme] reorganize “deeper shell integration” instructions Dec 5, 2023
ljharb
ljharb approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the unacceptably long delay :-) I've rebased this and due to some later improvements to the loading logic in bash, I dropped that consolidation part.

@ljharb ljharb merged commit 7aee54b into nvm-sh:master Dec 5, 2023
99 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
informational shell: bash/sh shell: zsh
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwiley4000 @ljharb