-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nw-gyp does not seem to support msvs 2015 #4033
Comments
Same issue, can not rebuild module while assigning msvs_version as 2015 |
I'm in the process of developing a node add-on have found node-gyp and nw-gyp very difficult to work with - however I have found a fix (although not entirely ideal, it does work) for the following error (posting the generic error so other people with this issue that are busy searching for a fix can find it):
The error will be thrown from a file called Follow the steps below, or just replace the contents of the file with the code below the steps.Open At line 379, there should be a dict called
At line 320, there should be a dict called
At line 207, there should be a dict called
You can follow the steps above, or replace the contents of the file with:
|
@Rob-- nope, still breaks for me... compilation of pipeline.cc fails with:
P.S. had to re-patch nw-gyp to also support the community edition MSVS (2015e)... Merry Christmas and a Happy New Year to everyone! Thanks! |
Just updated my comment and added Happy holidays to you too! |
@Rob-- thank you very much for your detailed walkthrough! |
@eugenesvk No problem! Happy to help :) |
Is this issue still reproduced on the latest nwjs build? |
On 0.22.3 the build goes through... Though comparing to node-gyp, nw-gyp throws a bunch of "unknown pragma" warnings in node_buffer.cc.... I'm building sharp (http://sharp.dimens.io/en/stable/) on Win10, x64....
(log: build.txt ) |
Or just |
It works fine for me on Windows 10:
|
close as fixed. |
When rebuilding via...
nw-gup crashes with: KeyError: '2015'
node-gyp works fine using msvs2015
The module I'm rebuilding is sharp (npm install sharp)
Thanks!
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: