Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My C++ module works on node 6.2.2 but it crashes on nwjs 0.15.4 for Linux #5086

Closed
cuongleqq opened this issue Jul 7, 2016 · 5 comments
Closed

Comments

@cuongleqq
Copy link

Hi,

Thanks for great work with nwjs.

I am trying to use 0.15.4 for my project. My module written in C++ and wrapped using node-ffi works well with nodejs 6.2.2 but when I tried to use it with nwjs 0.15.4, it crashed (I only tested on Linux)

In the console, it says

nw: ../../nan/nan.h:679: Nan::MaybeLocal<v8::Object> Nan::NewBuffer(char*, size_t, node::Buffer::FreeCallback, void*): Assertion `length <= imp::kMaxLength && "too large buffer"' failed.

Dump file
dump.zip

The simple sample code to reproduce the crash
https://github.com/cuongle121/nwjs-demo-0.15.4-crash

Thanks!
Cuong.

@rogerwang
Copy link
Member

It needs re-compile with the header files provided by NW. Previously we supported using node binary modules directly but now it's broken due to v8 ABI change.

@kailniris
Copy link

@rogerwang I read the issue about the v8 change and i am interested, is it possible to support node binary modules in the future again?

@rogerwang
Copy link
Member

@kailniris yes, as long as the ABI of different v8 versions in Node and Chromium are compatible. So let's wait for the next v8 upgrade in Node and see.

@rogerwang
Copy link
Member

close as duplicate of #5025

@cuongleqq
Copy link
Author

Thank you very much for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants