Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Reload: Migrate to System.Text.Json #390

Open
Jorteck opened this issue Oct 17, 2021 · 2 comments
Open

Plugin Reload: Migrate to System.Text.Json #390

Jorteck opened this issue Oct 17, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Jorteck
Copy link
Contributor

Jorteck commented Oct 17, 2021

With the addition of the NUI API, an extra dependency was added to Newtonsoft.Json due to its simplicity for serializing polymorphic objects.

Unfortunately it has a few issues from sometimes holding hard dependencies to plugins, preventing AssemblyLoadContexts from being unloading and causing hot reloads to fail.

@Jorteck Jorteck added the help wanted Extra attention is needed label Oct 17, 2021
@Jorteck
Copy link
Contributor Author

Jorteck commented Jan 25, 2022

Should not start working on this until we have appropriate test coverage: #463

@Samuel-IH
Copy link

Just saw this!
While this is a long ways away, I'd like to mention that System.Text.Json may not solve the issue. I've used it in one of my plugins to help with hot reloading with no success. I certainly could be missing something in my setup, but this issue was pretty convincing to me: dotnet/runtime#65323

I ended up having to use Jil instead: https://github.com/kevin-montrose/Jil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants