Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynamic option platform #1224

Open
1 of 3 tasks
zdev-online opened this issue Sep 11, 2024 · 1 comment
Open
1 of 3 tasks

Make dynamic option platform #1224

zdev-online opened this issue Sep 11, 2024 · 1 comment

Comments

@zdev-online
Copy link

Issue Type

  • Bug Report
  • Feature Request
  • Other

Please make folder dynamic here: https://github.com/nwutils/nw-builder/blob/7ca5a28f40078ab179aab72cf0f3260ef5f118f2/src/bld.js#L138C1-L150C6

From:

for (let file of files) {
    await fs.promises.cp(
      file,
      path.resolve(
        outDir,
        platform !== 'osx'
          ? 'package.nw'
          : 'nwjs.app/Contents/Resources/app.nw',
        file,
      ),
      { recursive: true, verbatimSymlinks: true },
    );
  }

To:

  // filesFolder - is option for build type options
  for (let file of files) {
     await fs.promises.cp(
       file,
       path.resolve(
         outDir,
         filesFolder,
         file,
       ),
       { recursive: true, verbatimSymlinks: true },
     );
   }
@ayushmanchhabra
Copy link
Collaborator

If you don't place the files in the correct directory, NW.js is unable to read them. Could you explain how the fileFolder option will be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants