Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create output file for samples that have no overlapping markers #23

Open
MareikeJaniak opened this issue Jun 7, 2023 · 0 comments
Open

Comments

@MareikeJaniak
Copy link

Hi!

We are using Conpair as part of a pipeline for a large project to ensure that samples from the same patient are properly paired. The tool is working well for us and we especially appreciate the integration with multiqc. However, to improve the visualization of samples with no overlapping markers in multiqc, we need an output file to be created for these files, instead of just a warning.

At the moment, no output file is created for samples with 0 overlapping markers, so the sample pair does not get included in the multiqc report. Including these sample pairs with concordance = 0.00% in the multiqc output would make it easier for us to spot problematic samples, which might otherwise be missed.

I've forked the repository and added a commit that solves this issue for our purposes:
MareikeJaniak@7bc3908

I realize that not everyone would want this behavior, so an option to toggle this on and off could be added. Let me know if you'd consider including this as a feature or option in a future release, happy to develop further a create a PR.

Best,
Mareike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant