Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagick support for PHP8 #2

Open
nickdunn opened this issue Jun 24, 2021 · 6 comments
Open

Imagick support for PHP8 #2

nickdunn opened this issue Jun 24, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@nickdunn
Copy link

https://github.com/nystudio107/docker-images/blob/master/php-prod-base/php-8.0-alpine/Dockerfile#L52

Just a quick heads up that a few days ago they published an Imagick version 3.5.0 with PHP8 compatibility. I'm using the following and it seems good so far:

pecl install  imagick-3.5.0
@nickdunn nickdunn added the bug Something isn't working label Jun 24, 2021
@khalwat
Copy link
Contributor

khalwat commented Jun 24, 2021

The problem is, it's apparently incompatible with the Imagine library that Craft uses

So I'm going to stick with the github commit hack until the dust settles. Appreciate the heads up tho!

@khalwat khalwat closed this as completed Jun 24, 2021
@nickdunn
Copy link
Author

Oh it is? I hadn't gone that far down the rabbit hole — thanks for the tip.

@nickdunn
Copy link
Author

Out of interest is there an open bug citing that incompatibility? With Craft 3.7-beta3 and PHP8 and Imagick 3.5.0 everything seems to be working as expected — resizing, cropping etc.

@khalwat
Copy link
Contributor

khalwat commented Jun 24, 2021

Looks like it is actually an issue with Craft's Imagine implementation:

php-imagine/Imagine#766

My guess is that they've fixed it in the 3.7 beta

@nickdunn
Copy link
Author

And fixed :-)

craftcms/cms#8095

@khalwat
Copy link
Contributor

khalwat commented Jun 24, 2021

Nice. I'll re-open this so I remember to add it back in

@khalwat khalwat reopened this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants