-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to ignore leap seconds after a given date #43
Comments
This is likely possible with a crate feature system: all of the leap seconds are enabled by default, but one could build hifitime without specific leap seconds. However, I would need to update the test suite so that "no default feature" doesn't disable all of the leap seconds. |
One way to support this is to allow providing a structure that reads the IERS Leap Seconds file. Then, one could create an epoch from that context. The best would be for that Epoch to be created with the same constructors, but I don't know whether that is possible because that would require an associated type to If a solution is found, then this should also be used for the UT1 computation. |
@cjordan If you have any idea on how I could implement an input file to read the data from, that would be great because the same method could be used to read from the EOP data. Looking at the code, it seems like the So I think that a new function could be created like: Then, I'd build another implementation of the LeapSecondProvider that reads from the leap seconds list published by the IERS. The same method should also work for support UT1, I think... |
Sorry for the delay, it's been a busy few days. I think your proposal makes sense. It would be useful to have the flexibility of defining your own "leap second provider". I guess my only concern would be how it affects existing users and "simple" usage of |
This is important as some simulation systems might not include all of the leap seconds. This is needed for validation of astrodynamics computations.
The text was updated successfully, but these errors were encountered: