-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is "Balance Distribution" showing shares instead of balances? #1545
Comments
UX wise we prob need Don answer here, other than that it was discussed in Figma |
Based on Andy's input shares are more accurate and actually accumulate to 100%. The initial idea from me was to show shares in a tooltip rather than showing both though. |
Balances will still accumulate to 100%. And ratios should still be equally accurate ( @Andrew7234 how can balance inaccuracies occur? Is it just: if indexing is 10 days behind, both balances will be approximately 2.5% / 365 * 10 = 0.068% too low? |
For calculating self delegations (or any user's staked balance with a validator) we end up rounding the balance to the nearest base unit. In practice this is a very small error since 1 rose = 10^9 base units, so it shouldn't make much of a difference to use shares/balance for percentage calculations. I initially liked the idea of using shares since Nexus tracks those explicitly, and they don't change as often due to epoch staking rewards. But I agree that the 'rose balance' should take precedence over the 'shares'. I like Don's suggestion of showing the balance by default and displaying shares in the tooltip/hover, does that sound ok? |
https://explorer.dev.oasis.io/testnet/consensus/validators/oasis1qpz97gfrvj5xzx8jx7x9zweeq0rcf2q6jg4a09qz
https://testnet.nexus.prd.oasis.io/v1/consensus/validators/oasis1qpz97gfrvj5xzx8jx7x9zweeq0rcf2q6jg4a09qz
The text was updated successfully, but these errors were encountered: