Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use serde #166

Closed
ryscheng opened this issue Apr 26, 2018 · 3 comments
Closed

Use serde #166

ryscheng opened this issue Apr 26, 2018 · 3 comments
Assignees
@kostko
Labels
c:runtime/compute Category: runtime compute worker p:1 Priority: core feature

Comments

@ryscheng
Copy link
Contributor

https://serde.rs/

It seems like there's boilerplate for implementing encodable/decodable for RLP right now. Why aren't we using serde, which automatically generates Serializable/Deserializable implementations for your structs?
https://serde.rs/derive.html
Then we get these serialization formats for free (e.g. JSON, CBOR, Messagepack).
@ryscheng ryscheng added the s:need more info Status: further information is requested label Apr 26, 2018
@ryscheng ryscheng mentioned this issue Apr 26, 2018
Closed
@ryscheng ryscheng changed the title Use serde? Use serde Apr 26, 2018
@ryscheng
Copy link
Contributor Author

The plan is to currently use serde-cbor. In the future, if we need serde-rlp or serde-protobuf, we will have to implement it. But at least this gets rid of our boilerplate code we have.

@ryscheng ryscheng added p:1 Priority: core feature c:runtime/compute Category: runtime compute worker and removed s:need more info Status: further information is requested labels Apr 26, 2018
@ryscheng ryscheng added this to the Testnet MVP milestone Apr 26, 2018
@kostko
Copy link
Member

kostko commented Apr 27, 2018

Implemented in #128.

@willscott
Copy link
Contributor

This can be closed, right?

@kostko kostko closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:runtime/compute Category: runtime compute worker p:1 Priority: core feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@willscott @kostko @ryscheng