Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper logging #40

Closed
ryscheng opened this issue Apr 1, 2018 · 1 comment
Closed

Use proper logging #40

ryscheng opened this issue Apr 1, 2018 · 1 comment
Assignees
@kostko
Labels
c:runtime/compute Category: runtime compute worker p:1 Priority: core feature

Comments

@ryscheng
Copy link
Contributor

ryscheng commented Apr 1, 2018 •
edited
Loading

We should use a proper Rust logging library everywhere instead of manually printing stuff.

how about log+fern?

Using log is an easy choice since it's going to be part of rust core. Of the options listed in the README, fern seemed to be the most actively maintained.

Does prometheus do logging? Might be good to use this since we already use it for tracing
@ryscheng ryscheng added p:1 Priority: core feature c:runtime/compute Category: runtime compute worker labels Apr 1, 2018
@ryscheng ryscheng added this to the MVP milestone Apr 2, 2018
@kostko kostko mentioned this issue Apr 5, 2018
Closed
This was referenced Apr 28, 2018
Merged
Merged
@kostko
Copy link
Member

kostko commented May 2, 2018 •
edited
Loading

Implemented for compute node (using log and the very simple pretty_env_logger as we can always easily change the logging frontend if we need something more complex) in #172.

@kostko kostko self-assigned this May 2, 2018
@willscott willscott mentioned this issue May 8, 2018
Merged
@Yawning Yawning mentioned this issue May 11, 2018
Closed
@kostko kostko closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:runtime/compute Category: runtime compute worker p:1 Priority: core feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kostko @ryscheng