-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Before transaction validate if ledger device still derives same account #1614
Conversation
Deploying with Cloudflare Pages
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good, great UX improvement!
src/locales/en/translation.json
Outdated
@@ -135,6 +135,7 @@ | |||
"reclaimedAmount": "Amount to reclaim" | |||
}, | |||
"errors": { | |||
"LedgerDerivedDifferentAccount": "This Ledger did not derive this account.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of the copy, would something like this be even clearer and easier to understand?
This account does not belong to the currently connected Ledger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
a642607
to
8bec3a7
Compare
This improves the error message for users mixing up multiple ledger devices.
8bec3a7
to
d182bfd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 82.96% 82.86% -0.11%
==========================================
Files 157 157
Lines 4075 4085 +10
Branches 730 731 +1
==========================================
+ Hits 3381 3385 +4
- Misses 694 700 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This improves the error message for users mixing up multiple ledger devices.
E.g.: