-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign towards settings page #1630
Conversation
lukaw3d
commented
Sep 4, 2023
Before | After |
---|---|
Deploying with Cloudflare Pages
|
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
- Coverage 82.95% 82.86% -0.09%
==========================================
Files 157 161 +4
Lines 4089 4150 +61
Branches 733 743 +10
==========================================
+ Hits 3392 3439 +47
- Misses 697 711 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
89b3cfe
to
8eeebd5
Compare
onClickManage: () => setLayerVisibility(true), | ||
}} | ||
/> | ||
{layerVisibility && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes; i'm not sure it's a problem after positioning it "top" instead of center https://github.com/oasisprotocol/oasis-wallet-web/blob/8eeebd546b51c124a08f1f5973057aacd00dab5d/src/app/components/Toolbar/Features/SettingsButton/index.tsx#L52-L54
8eeebd5
to
ebf5792
Compare