-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix continuously refreshing balances in wallet slice #1692
Conversation
await expect(page.getByTestId('account-balance-summary')).toContainText('123.0') | ||
await expect(page.getByTestId('account-choice')).toContainText('123.0') | ||
await mockApi(page, 456) | ||
await page.waitForRequest('**/chain/account/info/*', { timeout: 60_000 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slow test. ACCOUNT_REFETCHING_INTERVAL is 30 seconds. Not sure if we should change it for tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on NODE_ENV? that would be cool, on the other hand Cypress tests are slower than Playwright so not having that would not impact CI heavily. Anyway I'm fine with both, leaving it as is (and making GH issue) or extending PR with configurable interval based on env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the interval based on NODE_ENV, but suspiciously test still fails, exceeding timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to REACT_APP_E2E_TEST
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
+ Coverage 82.82% 82.85% +0.03%
==========================================
Files 178 175 -3
Lines 4560 4469 -91
Branches 815 797 -18
==========================================
- Hits 3777 3703 -74
+ Misses 783 766 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fa02cba
to
670b37b
Compare
Fixes making transactions with the refreshed balance and displays new balance in AccountSelector.
670b37b
to
b25b307
Compare
Fixes #1673
Fixes making transactions with the refreshed balance and displays new balance in AccountSelector.