Add Ionic Capacitor

[lubej]

Folders android and ios were auto generated with npx cap add [platform]. Android platform - example for Android.

npx cap add android
npx cap add ios

Assets for each platform were generated using @capacitor/assets

[buberdds]

Before adding all these MBs to repo we should run squoosh or some other optimizer.
sample splash png: 2.6MB -> (98% down) 38kB

[buberdds]

Do we need files for Win?

[lubej]

I wouldn't touch any of autogenerated scripts. Just to spend ages fixing it, if something breaks in the future.

[buberdds]

good that we have some test coverage here

we can remove ExampleUnitTest

[lubej]

I would still rather keep this, just in case there is no confusion if we need to generate android/ios platform from scratch, and wonder where did this file came from disappear. But if you are strongly against it, I can delete it as well.

[buberdds]

Can you provide requirements and steps how these files were generated - sorry I did not look into ionic since weeks and I remember nothing. thx

[lubej]

Can you provide requirements and steps how these files were generated - sorry I did not look into ionic since weeks and I remember nothing. thx

So all files inside android and ios folders are autogenerated.

npx cap add android
npx cap add ios

And I wouldn't change those files, I know there is some useless stuff in it - addressing some comments in the PR.

[lukaw3d]

What was the reason for including these autogenerated files into the repo again? Is it because of unavoidable modifications we need to make to them later on?

[lubej]

What was the reason for including these autogenerated files into the repo again? Is it because of unavoidable modifications we need to make to them later on?

Yeah. Even though we could in theory just commit diffs, and overwrite generated files on postinstall script. But i am not sure if different version of ionic will generate the same files.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@capacitor/[email protected]	Transitive: network	+2	749 kB	ionicjs
npm/@capacitor/[email protected]	environment, filesystem, network, shell	+90	9.94 MB	ionicjs
npm/@capacitor/[email protected]	Transitive: network	+2	676 kB	ionicjs
npm/@ionic/[email protected]	filesystem Transitive: environment	+10	1.1 MB	ionicjs
npm/@ionic/[email protected]	environment	+15	215 kB	ionicjs
npm/[email protected]	environment, filesystem, shell	0	173 kB	abetomo
npm/[email protected]	None	+3	1.2 MB	mreinstein
npm/[email protected]	None	0	66.2 kB	isaacs

View full report↗︎

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a59f787) 81.19% compared to head (ceea95c) 81.37%.

❗ Current head ceea95c differs from pull request most recent head b584201. Consider uploading reports for the commit b584201 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1769      +/-   ##
==========================================
+ Coverage   81.19%   81.37%   +0.18%     
==========================================
  Files         192      192              
  Lines        5067     5042      -25     
  Branches      932      923       -9     
==========================================
- Hits         4114     4103      -11     
+ Misses        953      939      -14     

Flag	Coverage Δ
cypress	46.05% <ø> (-0.16%)	⬇️
jest	77.16% <ø> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes