Denser tab buttons in settings #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukaw3d
commented
Apr 24, 2024
lukaw3d
commented
| Before | After |
|---|---|
 |
 |
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Apr 25, 2024
| @@ -5,7 +5,7 @@ | |||
| <title>ROSE Wallet Extension</title> | |||
| </head> | |||
| <body> | |||
| <div id="root" style="min-width: 360px; min-height: 600px"></div> | |||
| <div id="root" style="min-width: 375px; min-height: 600px"></div> | |||
There was a problem hiding this comment.
Aligning popup width to EN tab labels seems naive. Anyway, if we need more space can we go with current/old extension 450 instead? More langs will look Ok. Maybe we should use "Accounts" label too to save some space. It's quite clear that accounts listed under profile belong to user.
There was a problem hiding this comment.
I'd like a wider extension too, and we can update that very easily, but we'll probably want to support 375px iphones either way
lubej
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.