Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use eth private key that starts with 0x - version 2 #1923

Merged
merged 3 commits into from
May 15, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented May 7, 2024

Closes #1868

  • keep changes limited to TansactionRecipient
  • add ethPrivateRawKey field to transaction form

Copy link

github-actions bot commented May 7, 2024

Deployed to Cloudflare Pages

Latest commit: 046cee03b6b6df98d0d4113fa40aa3aa3498fea0
Status:✅ Deploy successful!
Preview URL: https://77909fdf.oasis-wallet.pages.dev

@buberdds buberdds changed the title Mz/priv key 2 Allow to use eth private key that starts with 0x May 7, 2024
@buberdds buberdds changed the title Allow to use eth private key that starts with 0x Allow to use eth private key that starts with 0x - version 2 May 7, 2024
@buberdds buberdds marked this pull request as ready for review May 7, 2024 10:57
@buberdds buberdds requested a review from lukaw3d May 10, 2024 06:38
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ethPrivateKey: string
// provided by user and used in form inputs allowing back and forth form navigation
ethPrivateRawKey: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd name it ethPrivateKeyRaw so it would show up in the searches I did a few months ago, looking for leaks of anything named privatekey)

@buberdds buberdds merged commit f2204a5 into master May 15, 2024
13 checks passed
@buberdds buberdds deleted the mz/privKey-2 branch May 15, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim 0x from the Ethereum Private key
2 participants