Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android update screen #1945

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add Android update screen #1945

merged 6 commits into from
Jun 6, 2024

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented May 21, 2024

Solution

Adds an update screen, when update is available on mobile platforms(currently only implemented for Android platform). Where clicking on "Update now" takes the user to the app store page.

Resources

localhost_3000_(iPhone 12 Pro)

Copy link

github-actions bot commented May 21, 2024

Deployed to Cloudflare Pages

Latest commit: 202c9d02dfc346596a12c68012d0aabf2b5092c2
Status:✅ Deploy successful!
Preview URL: https://01006ae1.oasis-wallet.pages.dev

Copy link

socket-security bot commented May 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Install scripts npm/@swc/[email protected]
  • Install script: postinstall
  • Source: node postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@lubej
Copy link
Collaborator Author

lubej commented May 21, 2024

Note to self: Does update check run after user enters the wallet again. It should check only once, and then maybe once per day?

@lubej lubej force-pushed the ml/app-update-wall branch 4 times, most recently from db57985 to 69a7220 Compare June 3, 2024 09:46
@lubej lubej changed the title Add Android update wall Add Android update screen Jun 3, 2024
@lubej
Copy link
Collaborator Author

lubej commented Jun 3, 2024

Note to self: Does update check run after user enters the wallet again. It should check only once, and then maybe once per day?

Current implementation checks for an update only on app launch. Which should be sufficient for current case, as the update can be skipped anyway. When mandatory update feature start to roll out, we should revisit the topic on what time interval the update check should be implemented.

@lubej lubej requested a review from lukaw3d June 3, 2024 13:15
@lubej lubej marked this pull request as ready for review June 3, 2024 13:15
@lubej lubej requested review from buberdds and csillag June 3, 2024 13:15
@lubej lubej force-pushed the ml/app-update-wall branch 4 times, most recently from 474422c to 873ac82 Compare June 4, 2024 14:38
src/locales/en/translation.json Outdated Show resolved Hide resolved
src/app/components/Ionic/providers/IonicProvider.tsx Outdated Show resolved Hide resolved
@lubej lubej force-pushed the ml/app-update-wall branch 2 times, most recently from fa89f31 to bf6b091 Compare June 6, 2024 04:12
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 47.50000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 79.70%. Comparing base (fa2db40) to head (fa89f31).
Report is 12 commits behind head on master.

Current head fa89f31 differs from pull request most recent head 202c9d0

Please upload reports for the commit 202c9d0 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1945      +/-   ##
==========================================
- Coverage   80.24%   79.70%   -0.54%     
==========================================
  Files         203      210       +7     
  Lines        5289     5411     +122     
  Branches      974     1001      +27     
==========================================
+ Hits         4244     4313      +69     
- Misses       1045     1098      +53     
Flag Coverage Δ
cypress 43.90% <19.23%> (-0.62%) ⬇️
jest 75.82% <45.83%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ents/Ionic/hooks/useIonicAppStateChangeListener.ts 31.57% <ø> (ø)
src/app/components/Ionic/providers/IonicContext.ts 100.00% <100.00%> (ø)
src/app/index.tsx 100.00% <100.00%> (ø)
src/styles/theme/ThemeProvider.tsx 96.77% <ø> (ø)
...c/components/IonicNativePlatformProvider/index.tsx 85.71% <85.71%> (ø)
src/styles/theme/icons/mui-icons/MuiWalletIcon.tsx 60.00% <60.00%> (ø)
...c/app/components/Ionic/providers/IonicProvider.tsx 46.66% <46.66%> (ø)
...p/components/Ionic/hooks/useIonicRequiresUpdate.ts 25.00% <25.00%> (ø)
...app/components/Ionic/utils/capacitor-app-update.ts 23.80% <23.80%> (ø)
...mponents/Ionic/components/RequiresUpdate/index.tsx 46.66% <46.66%> (ø)

... and 5 files with indirect coverage changes

@lubej lubej force-pushed the ml/app-update-wall branch 2 times, most recently from af2c269 to 25d8858 Compare June 6, 2024 04:26
@lubej lubej merged commit 5d3daa9 into master Jun 6, 2024
12 of 13 checks passed
@lubej lubej deleted the ml/app-update-wall branch June 6, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants