Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ontology importer fixes (including db v.2) #247

Merged
merged 9 commits into from
Dec 29, 2022
Merged

Ontology importer fixes (including db v.2) #247

merged 9 commits into from
Dec 29, 2022

Conversation

MariaRosariaFraraccio
Copy link
Contributor

No description provided.

@MariaRosariaFraraccio MariaRosariaFraraccio linked an issue Dec 13, 2022 that may be closed by this pull request
[BUG]: Inserimento assiomi con stessa forma in Manchester syntax in db durante importazione #240
Closed
@MariaRosariaFraraccio
Copy link
Contributor Author

Ho aggiunto delle tabelle "temporanee" (non sono effettivamente temporary tables perché altrimenti si perdevano nei cambi di connessione al db) per importation e drawn, così che in una stessa sessione si possano distinguere gli inserimenti nel db che vanno salvati e quelli che vanno rimossi.

Il problema del salvataggio invece era legato al salvataggio da pulsante invece che alla chiusura del progetto, perché in quel caso veniva lanciato comunque il segnale per la rimozione delle importazioni dal db.

@mnamici
Copy link
Collaborator

mnamici commented Dec 28, 2022 •
edited
Loading

Al momento ottengo il seguente errore quando provo ad importare un'ontologia:

Traceback (most recent call last):
  File "/home/manuel/Workspace/eddy/eddy/plugins/ontology-importer/ontology_importer.py", line 1158, in doOpenOntologyFile
    raise e
  File "/home/manuel/Workspace/eddy/eddy/plugins/ontology-importer/ontology_importer.py", line 1104, in doOpenOntologyFile
    conn.executescript("""CREATE TABLE IF NOT EXISTS temp_drawn (
sqlite3.OperationalError: near ";": syntax error

Manca la parentesi di chiusura nello statement menzionato.

@mnamici
Copy link
Collaborator

mnamici commented Dec 28, 2022

Ok ora sembra che il salvataggio funzioni insieme all'upgrade di versione del db.

mnamici
mnamici requested changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@mnamici mnamici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ricorda che il database è condiviso tra le varie sessioni (progetti aperti). Da quello che vedo le tabelle vengono cancellate al salvataggio, quindi due progetti fanno interferenza tra loro
(salvando uno si cancellano le cose temporanee dell'altro).

eddy/ui/session.py Outdated Show resolved Hide resolved
eddy/ui/session.py Outdated Show resolved Hide resolved
mnamici
mnamici requested changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@mnamici mnamici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un ultimo paio di osservazioni. In sostanza secondo me session non dovrebbe uscire modificato da questa PR, ci sta già tutto quello che serve mi sembra.

eddy/ui/session.py Outdated Show resolved Hide resolved
eddy/ui/session.py Outdated Show resolved Hide resolved
eddy/ui/session.py Outdated Show resolved Hide resolved
eddy/ui/session.py Outdated Show resolved Hide resolved
eddy/plugins/ontology-importer/ontology_importer.py Show resolved Hide resolved
rooosyf added 3 commits December 29, 2022 17:08
@mnamici
plugins: ontology-importer: added temporary tables for correct import…
d73a134 
…ations saving
@mnamici
plugins: ontology-importer: connected sgnProjectSaved and added check…
7283cce 
… on session_id on temp tables
@mnamici
ui: session: emit sgnNoSaveProject only when closing without saving
b252f06 
Previous to this, the signal was emitted even when the project
was closed from a clean state, i.e. without changes triggering
the confirmation dialog, and resulted in the unintended removal
of any importation process started during the current session.
@mnamici
Copy link
Collaborator

mnamici commented Dec 29, 2022

Visto che c'erano alcune modifiche che si annullano ho fatto squash di alcuni degli ultimi commit, fai force pull.

@mnamici mnamici merged commit e04947e into obdasystems:develop Dec 29, 2022
@mnamici mnamici mentioned this pull request Dec 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnamici mnamici mnamici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Inserimento assiomi con stessa forma in Manchester syntax in db durante importazione
2 participants
@MariaRosariaFraraccio @mnamici