diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/TranspileMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/TranspileMojo.java index 3e43565215..bbe8f468f6 100644 --- a/eo-maven-plugin/src/main/java/org/eolang/maven/TranspileMojo.java +++ b/eo-maven-plugin/src/main/java/org/eolang/maven/TranspileMojo.java @@ -246,7 +246,7 @@ private List transpile( /** * Clean up dirty classes. - * The method is trying to fix problem produced by dirty libraries: + * The method is trying to fix a problem produced by dirty libraries: * eo-strings example * Some libraries by mistake can put ALL their compiled classes right into the final library * jar, instead of only adding atoms. This can cause different runtime errors since the @@ -265,12 +265,18 @@ private List transpile( * {@link java.nio.file.AccessDeniedException}, which could crash the build. * _____ * @param java The list of java files. - * @todo #2375:90min. Add concurrency tests for the TranspileMojo.cleanUpClasses method. - * We should be sure that the method works correctly in a concurrent environment. - * In order to do so we should add a test that will run the cleanUpClasses method in - * multiple threads and check that the method works correctly without exceptions. - * We can apply the same approach as mentioned in that post: - * Post + * @todo #2375:90min. Implement a mechanism for "internal" and "external" classes. + * - "internal" classes will be included in the catalog + * - "external" classes will be placed in another directory. + * For example, external classes will be placed in directories + * where the top level will be the name of the package from + * which the object is connected, and the subdirectories + * will indicate the version of this package. + * Another solution is to create an analogue of `implementation` and `api` from gradle: + * - implementation – just includes a dependency for internal use + * - api – allows API users use a dependency that + * was added to the project using the keyword `api` + *

More about api and implementation here */ private void cleanUpClasses(final Collection java) { final Set unexpected = java.stream()