From 02e0730997fa9b062a34cacc59df1449b832c76d Mon Sep 17 00:00:00 2001 From: Michael MacCallum Date: Tue, 29 May 2018 11:33:45 -0400 Subject: [PATCH 1/3] modernized project settings --- DRWindows/DRWindows.xcodeproj/project.pbxproj | 39 +++++++++++++++++-- DRWindows/DRWindows/DRWindows-Info.plist | 2 +- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/DRWindows/DRWindows.xcodeproj/project.pbxproj b/DRWindows/DRWindows.xcodeproj/project.pbxproj index 5216172..f583f6a 100644 --- a/DRWindows/DRWindows.xcodeproj/project.pbxproj +++ b/DRWindows/DRWindows.xcodeproj/project.pbxproj @@ -181,7 +181,7 @@ isa = PBXProject; attributes = { CLASSPREFIX = DR; - LastUpgradeCheck = 0500; + LastUpgradeCheck = 0930; ORGANIZATIONNAME = "Danny Ricciotti"; TargetAttributes = { 3046D2FA17B5638000CD8B29 = { @@ -275,30 +275,45 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; + CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; + CLANG_WARN_SUSPICIOUS_MOVE = YES; + CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; COPY_PHASE_STRIP = NO; + ENABLE_STRICT_OBJC_MSGSEND = YES; + ENABLE_TESTABILITY = YES; GCC_C_LANGUAGE_STANDARD = gnu99; GCC_DYNAMIC_NO_PIC = NO; + GCC_NO_COMMON_BLOCKS = YES; GCC_OPTIMIZATION_LEVEL = 0; GCC_PREPROCESSOR_DEFINITIONS = ( "DEBUG=1", "$(inherited)", ); GCC_SYMBOLS_PRIVATE_EXTERN = NO; + GCC_WARN_64_TO_32_BIT_CONVERSION = YES; GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 7.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.0; ONLY_ACTIVE_ARCH = YES; SDKROOT = iphoneos; }; @@ -312,24 +327,38 @@ CLANG_CXX_LIBRARY = "libc++"; CLANG_ENABLE_MODULES = YES; CLANG_ENABLE_OBJC_ARC = YES; + CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES; CLANG_WARN_BOOL_CONVERSION = YES; + CLANG_WARN_COMMA = YES; CLANG_WARN_CONSTANT_CONVERSION = YES; + CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES; CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR; CLANG_WARN_EMPTY_BODY = YES; CLANG_WARN_ENUM_CONVERSION = YES; + CLANG_WARN_INFINITE_RECURSION = YES; CLANG_WARN_INT_CONVERSION = YES; + CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES; + CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES; + CLANG_WARN_OBJC_LITERAL_CONVERSION = YES; CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR; + CLANG_WARN_RANGE_LOOP_ANALYSIS = YES; + CLANG_WARN_STRICT_PROTOTYPES = YES; + CLANG_WARN_SUSPICIOUS_MOVE = YES; + CLANG_WARN_UNREACHABLE_CODE = YES; CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; COPY_PHASE_STRIP = YES; ENABLE_NS_ASSERTIONS = NO; + ENABLE_STRICT_OBJC_MSGSEND = YES; GCC_C_LANGUAGE_STANDARD = gnu99; + GCC_NO_COMMON_BLOCKS = YES; + GCC_WARN_64_TO_32_BIT_CONVERSION = YES; GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR; GCC_WARN_UNDECLARED_SELECTOR = YES; GCC_WARN_UNINITIALIZED_AUTOS = YES; GCC_WARN_UNUSED_FUNCTION = YES; GCC_WARN_UNUSED_VARIABLE = YES; - IPHONEOS_DEPLOYMENT_TARGET = 7.0; + IPHONEOS_DEPLOYMENT_TARGET = 8.0; SDKROOT = iphoneos; VALIDATE_PRODUCT = YES; }; @@ -340,9 +369,11 @@ buildSettings = { ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage; + DEVELOPMENT_TEAM = ""; GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "DRWindows/DRWindows-Prefix.pch"; INFOPLIST_FILE = "DRWindows/DRWindows-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "us.theredb.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = app; }; @@ -353,9 +384,11 @@ buildSettings = { ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage; + DEVELOPMENT_TEAM = ""; GCC_PRECOMPILE_PREFIX_HEADER = YES; GCC_PREFIX_HEADER = "DRWindows/DRWindows-Prefix.pch"; INFOPLIST_FILE = "DRWindows/DRWindows-Info.plist"; + PRODUCT_BUNDLE_IDENTIFIER = "us.theredb.${PRODUCT_NAME:rfc1034identifier}"; PRODUCT_NAME = "$(TARGET_NAME)"; WRAPPER_EXTENSION = app; }; diff --git a/DRWindows/DRWindows/DRWindows-Info.plist b/DRWindows/DRWindows/DRWindows-Info.plist index 8f929e5..5860c3f 100644 --- a/DRWindows/DRWindows/DRWindows-Info.plist +++ b/DRWindows/DRWindows/DRWindows-Info.plist @@ -9,7 +9,7 @@ CFBundleExecutable ${EXECUTABLE_NAME} CFBundleIdentifier - us.theredb.${PRODUCT_NAME:rfc1034identifier} + $(PRODUCT_BUNDLE_IDENTIFIER) CFBundleInfoDictionaryVersion 6.0 CFBundleName From 38057cb6356149c633efcee111736ddf5f453f9f Mon Sep 17 00:00:00 2001 From: Michael MacCallum Date: Tue, 29 May 2018 11:33:53 -0400 Subject: [PATCH 2/3] fixed block deprecation warning --- DRWindows/DRWindows/DRWindows/DRWindowController.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DRWindows/DRWindows/DRWindows/DRWindowController.h b/DRWindows/DRWindows/DRWindows/DRWindowController.h index b733975..9e73bdb 100644 --- a/DRWindows/DRWindows/DRWindows/DRWindowController.h +++ b/DRWindows/DRWindows/DRWindows/DRWindowController.h @@ -8,7 +8,7 @@ #import -typedef void (^DRWindowCompletionBlock)(); +typedef void (^DRWindowCompletionBlock)(void); @interface DRWindowController : UIViewController From b9a1b6676f13cced34221656366d81e053191abb Mon Sep 17 00:00:00 2001 From: Michael MacCallum Date: Tue, 29 May 2018 11:35:38 -0400 Subject: [PATCH 3/3] bumped version to 1.0.3 --- DRWindowController.podspec | 4 ++-- DRWindows/DRWindows/DRWindows-Info.plist | 4 ++-- README.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/DRWindowController.podspec b/DRWindowController.podspec index d526100..8f41231 100644 --- a/DRWindowController.podspec +++ b/DRWindowController.podspec @@ -1,13 +1,13 @@ Pod::Spec.new do |s| s.name = 'DRWindowController' - s.version = '1.0.2' + s.version = '1.0.3' s.platform = :ios s.ios.deployment_target = '5.0' s.license = 'Creative Commons Attribution Non-Commercial License' s.summary = 'An Objective-C / Cocoa Touch class for managing a vertical "stack" of UIViews and UIViewControllers.' s.homepage = 'https://github.com/objectiveSee/DRWindowController' - s.source = { :git => 'https://github.com/objectiveSee/DRWindowController.git', :tag => "1.0.2"} + s.source = { :git => 'https://github.com/objectiveSee/DRWindowController.git', :tag => "1.0.3"} s.source_files = 'DRWindows/DRWindows/DRWindows/DRWindowController*' s.requires_arc = true s.author = { "Danny Ricciotti" => "fakeemail@dontemailme.com" } diff --git a/DRWindows/DRWindows/DRWindows-Info.plist b/DRWindows/DRWindows/DRWindows-Info.plist index 5860c3f..3af9604 100644 --- a/DRWindows/DRWindows/DRWindows-Info.plist +++ b/DRWindows/DRWindows/DRWindows-Info.plist @@ -17,11 +17,11 @@ CFBundlePackageType APPL CFBundleShortVersionString - 1.0 + 1.0.3 CFBundleSignature ???? CFBundleVersion - 1.0 + 4.0 LSRequiresIPhoneOS UIRequiredDeviceCapabilities diff --git a/README.md b/README.md index 784d051..407ad0a 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ An Objective-C / Cocoa Touch class for managing a vertical "stack" of UIViews an [CocoaPods](http://cocoapods.org) is a dependency manager for Objective-C, which automates and simplifies the process of using 3rd-party libraries like AFNetworking in your projects. See the ["Getting Started" guide for more information](https://github.com/AFNetworking/AFNetworking/wiki/Getting-Started-with-AFNetworking). ```ruby -pod 'DRWindowController', '~> 1.0' +pod 'DRWindowController', '~> 1.0.3' ``` ## Show me what this magic is! ##