Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'React/RCTBridgeModule.h' file not found - 10.0.1 breaks with RN < 0.71.0 (0.70 is still officially supported) #1570

Closed
2 tasks done
Sunhat opened this issue Nov 15, 2023 · 9 comments · Fixed by #1579
Closed
2 tasks done

Comments

@Sunhat
Copy link

Sunhat commented Nov 15, 2023

Environment

macOS Sonoma 14.0
XCode 15.0.1
Target: iOS
RN Vector Icons version: 10.0.2
React Native: 0.70.14

Description

/node_modules/react-native-vector-icons/RNVectorIconsManager/RNVectorIconsManager.h:9:9: 'React/RCTBridgeModule.h' file not found

#import <React/RCTBridgeModule.h>
^~~~~~~~~~~~~~~~~~~

Duplicate of this closed ticket from 2017, as you can see, others recently are responding.
#385
#380

Attempts to fix

  • rm -rf Pods/ && rm Podfile.lock && pod install
  • clean build folder ios

Reproducible Demo

I can only imagine using the described versions above would re-produce. I don't appear to be alone here.

@Sunhat
Copy link
Author

Sunhat commented Nov 15, 2023

I found a likely cause of the problem. In React Native Vector Icons PR 1550, a commit was made to
"[Bring podspec in line with [NEW ARCH]"
https://github.com//pull/1550/files

This commit includes the use of a new method introduced in RN 0.72.0

https://github.com/facebook/react-native/blob/v0.72.0/packages/react-native/scripts/react_native_pods.rb

Therefore, this commit would be enough to warrant RN Vector Icons to have released v11.0.0

As this method controls New vs Old Arch deps, it's likely what's breaking builds with RN < 0.72.0

Please could you fix this in a 10.0.3 patch?... and if so desired, release 11.0.0

Thanks

@Sunhat Sunhat changed the title 'React/RCTBridgeModule.h' file not found 'React/RCTBridgeModule.h' file not found - 10.0.1 breaks with RN < 0.72.0 Nov 15, 2023
@nnmtesuji
Copy link

@Sunhat is it fixed?

@nnmtesuji
Copy link

same problem here :(

@fakingfantastic
Copy link

Also experienced this issue. Confirmed that locking the package to version 10.0.0 fix it for me

@Rassell
Copy link

Rassell commented Nov 24, 2023

Also experienced this issue. Confirmed that locking the package to version 10.0.0 fix it for me

Same here... thanks for the quickfix!

@Sunhat
Copy link
Author

Sunhat commented Nov 25, 2023

@fakingfantastic @Rassell Yes, locking to 10.0.0 does fix, however, this version does have a memory leak

@JaakkoKammonen
Copy link

JaakkoKammonen commented Nov 27, 2023

I have react-native 0.70.6 and the fix was to downgrade to version 9.2.0 of vector icons.

EDIT: In my package.json i had "react-native-vector-icons": "^10.0.0", and changed to "react-native-vector-icons": "10.0.0"

@Sunhat
Copy link
Author

Sunhat commented Nov 27, 2023

@JaakkoKammonen I am using 0.70.14 with 10.0.0 vector icons. I would recommend double checking this.

It may be in your package.json that you had "^10.0.0", the ^ will install the latest 10.0.x version, meaning 10.0.2.

Try specifically "react-native-vector-icons": "10.0.0" - otherwise I'm not sure, and thanks for commenting to help others

@JaakkoKammonen
Copy link

JaakkoKammonen commented Nov 27, 2023

@Sunhat My bad... Thank you! I edited my last comment so others dont make the same mistake as i did.

@Sunhat Sunhat changed the title 'React/RCTBridgeModule.h' file not found - 10.0.1 breaks with RN < 0.72.0 'React/RCTBridgeModule.h' file not found - 10.0.1 breaks with RN < 0.71.0 (0.70 is still officially supported) Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants