Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octicons Icons Not Horizontally Centered #790

Closed
arosendorff opened this issue Jul 23, 2018 · 4 comments · Fixed by #796
Closed

Octicons Icons Not Horizontally Centered #790

arosendorff opened this issue Jul 23, 2018 · 4 comments · Fixed by #796

Comments

@arosendorff
Copy link

It appears that the Icons in the Octicons font are not horizontally centered. This causes issues when attempting to use them in my projects, as you can see below:

screen shot 2018-07-23 at 21 06 09

This appears to be a problem with the font, as the alignment issues can also be seen on the icon preview page:

screen shot 2018-07-23 at 21 20 22

As far as I can see, it is only the Octicons font with this issue.
@oblador
Copy link
Owner

oblador commented Jul 24, 2018

That's probably a fontcustom issue, would you mind playing around with the settings and make a PR if you succeed?

@arosendorff
Copy link
Author

Sounds good, I will do that!

@oblador
Copy link
Owner

oblador commented Jul 27, 2018

Any luck?

@arosendorff
Copy link
Author

Sorry I haven't had a chance yet, work is pretty hectic! I'm going to try play around with it this weekend.

@hampustagerud hampustagerud mentioned this issue Jul 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Octicons hampustagerud/react-native-vector-icons
2 participants
@oblador @arosendorff