Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Unrecognized Operation" messages for Transfers with params and batch transfers #154

Open
jevonearth opened this issue Aug 18, 2020 · 6 comments

Comments

@jevonearth
Copy link

When asking the ledger to sign operations with params, we get the message "Unrecognized Operation" which is not reassuring to the user.

I understand screen real estate on the Ledger devices is tight.

Can we update the app to print "TX with params from SOURCE to DEST amount AMOUNT"

I believe a similar improvement can be made for batch operations, although I have not verified this yet.

@roxaneletourneau
Copy link

roxaneletourneau commented Aug 18, 2020

In addition to @jevonearth 's comment, we noticed that the unrecognized operation message is displayed when we are working with smart contracts (deploy and calling a method).

@andrewpaulicek
Copy link

I think we really need this.

"TX with params from SOURCE to DEST amount AMOUNT" would be perfect.

@mikereinhart
Copy link
Collaborator

Hi - was the behavior you're asking for observable for you on versions prior to the current release?

@utdrmac
Copy link

utdrmac commented Nov 20, 2020

Jumping in here:

If I try to send 1 transaction, ledger shows everything correctly. It decodes the bytes to show you source, destination, fee, etc.

But if I attempt to use the new batch transaction feature, sending 2+ in a single operation, the ledger doesn't know how to decode the bytes in such a way to present all of the info to you. Thus, it says it's unrecognized and shows you the signature of the decoded bytes.

This is a critical issue with the new tezos-client v8.

@mikereinhart
Copy link
Collaborator

Thanks @utdrmac, what do you think would be the best UX for a situation like this? Seems it might be too much to prompt for each tx in the batch, but I'm interested in your thoughts on this. Perhaps some aggregate information on the total amount being transferred?

Sounds like the current behavior you are seeing is the 'Sign Hash' functionality where the operation is hashed both on-device and (tezos-) client side for the user to verify in absence of the app's ability to produce a more informative prompt.

@utdrmac
Copy link

utdrmac commented Nov 23, 2020

@mikereinhart Certainly too much info to display. Especially for bakers that do payouts with 100's of txns per operation. And now with Delphi lowering txn costs, easily 500+ txns per op.
I think displaying the total amount is good and continuing to show the calculated hash so users can verify on-screen and on-device. Maybe also display the number of txns within the op?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants