Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] websocket (3 packages) (2.17) #26509

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

vbmithr
Copy link
Contributor

@vbmithr vbmithr commented Sep 7, 2024

Websocket library

CHANGES:

CHANGES:

- adapt to mirage-crypto (@copy)
- use mirage-crypto-rng as csprng (@ushitora-anqou)
@shonfeder
Copy link
Collaborator

Hello! Thanks for the release :)

Looks like a number of failures showing up in CI, beginning with

#=== ERROR while compiling websocket.2.17 =====================================#
# context              2.3.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.08.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.08/.opam-switch/build/websocket.2.17
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p websocket -j 31 --promote-install-files=false @install
# exit-code            1
# env-file             ~/.opam/log/websocket-7-8e6f49.env
# output-file          ~/.opam/log/websocket-7-8e6f49.out
### output ###
# (cd _build/default && /home/opam/.opam/4.08/bin/ocamlc.opt -w -40 -g -bin-annot -I core/.websocket.objs/byte -I /home/opam/.opam/4.08/lib/angstrom -I /home/opam/.opam/4.08/lib/astring -I /home/opam/.opam/4.08/lib/base/caml -I /home/opam/.opam/4.08/lib/base64 -I /home/opam/.opam/4.08/lib/bigstringaf -I /home/opam/.opam/4.08/lib/bytes -I /home/opam/.opam/4.08/lib/cohttp -I /home/opam/.opam/4.08/lib/conduit -I /home/opam/.opam/4.08/lib/cstruct -I /home/opam/.opam/4.08/lib/domain-name -I /home/opam/.opam/4.08/lib/eqaf -I /home/opam/.opam/4.08/lib/eqaf/bigstring -I /home/opam/.opam/4.08/lib/eqaf/cstruct -I /home/opam/.opam/4.08/lib/ipaddr -I /home/opam/.opam/4.08/lib/ipaddr-sexp -I /home/opam/.opam/4.08/lib/macaddr -I /home/opam/.opam/4.08/lib/mirage-crypto -I /home/opam/.opam/4.08/lib/mirage-crypto-rng -I /home/opam/.opam/4.08/lib/ocplib-endian -I /home/opam/.opam/4.08/lib/parsexp -I /home/opam/.opam/4.08/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.08/lib/re -I /home/opam/.opam/4.08/lib/seq -I /home/opam/.opam/4.08/lib/sexplib -I /home/opam/.opam/4.08/lib/sexplib0 -I /home/opam/.opam/4.08/lib/stringext -I /home/opam/.opam/4.08/lib/uri -I /home/opam/.opam/4.08/lib/uri-sexp -intf-suffix .ml -no-alias-deps -open Websocket__ -o core/.websocket.objs/byte/websocket.cmo -c -impl core/websocket.ml)
# File "core/websocket.ml", line 1:
# Error: The implementation core/websocket.ml
#        does not match the interface core/.websocket.objs/byte/websocket.cmi:
#        In module Rng:
#        Modules do not match:
#          sig val init : unit -> int -> Cstruct.t end
#        is not included in
#          sig val init : unit -> int -> string end
#        In module Rng:
#        Values do not match:
#          val init : unit -> int -> Cstruct.t
#        is not included in
#          val init : unit -> int -> string
#        File "core/websocket.mli", line 25, characters 2-34:
#          Expected declaration
#        File "core/websocket.ml", line 24, characters 6-10: Actual declaration
# (cd _build/default && /home/opam/.opam/4.08/bin/ocamlopt.opt -w -40 -g -I core/.websocket.objs/byte -I core/.websocket.objs/native -I /home/opam/.opam/4.08/lib/angstrom -I /home/opam/.opam/4.08/lib/astring -I /home/opam/.opam/4.08/lib/base/caml -I /home/opam/.opam/4.08/lib/base64 -I /home/opam/.opam/4.08/lib/bigstringaf -I /home/opam/.opam/4.08/lib/bytes -I /home/opam/.opam/4.08/lib/cohttp -I /home/opam/.opam/4.08/lib/conduit -I /home/opam/.opam/4.08/lib/cstruct -I /home/opam/.opam/4.08/lib/domain-name -I /home/opam/.opam/4.08/lib/eqaf -I /home/opam/.opam/4.08/lib/eqaf/bigstring -I /home/opam/.opam/4.08/lib/eqaf/cstruct -I /home/opam/.opam/4.08/lib/ipaddr -I /home/opam/.opam/4.08/lib/ipaddr-sexp -I /home/opam/.opam/4.08/lib/macaddr -I /home/opam/.opam/4.08/lib/mirage-crypto -I /home/opam/.opam/4.08/lib/mirage-crypto-rng -I /home/opam/.opam/4.08/lib/ocplib-endian -I /home/opam/.opam/4.08/lib/parsexp -I /home/opam/.opam/4.08/lib/ppx_sexp_conv/runtime-lib -I /home/opam/.opam/4.08/lib/re -I /home/opam/.opam/4.08/lib/seq -I /home/opam/.opam/4.08/lib/sexplib -I /home/opam/.opam/4.08/lib/sexplib0 -I /home/opam/.opam/4.08/lib/stringext -I /home/opam/.opam/4.08/lib/uri -I /home/opam/.opam/4.08/lib/uri-sexp -intf-suffix .ml -no-alias-deps -open Websocket__ -o core/.websocket.objs/native/websocket.cmx -c -impl core/websocket.ml)
# File "core/websocket.ml", line 1:
# Error: The implementation core/websocket.ml
#        does not match the interface core/.websocket.objs/byte/websocket.cmi:
#        In module Rng:
#        Modules do not match:
#          sig val init : unit -> int -> Cstruct.t end
#        is not included in
#          sig val init : unit -> int -> string end
#        In module Rng:
#        Values do not match:
#          val init : unit -> int -> Cstruct.t
#        is not included in
#          val init : unit -> int -> string
#        File "core/websocket.mli", line 25, characters 2-34:
#          Expected declaration
#        File "core/websocket.ml", line 24, characters 6-10: Actual declaration



<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
+- The following actions failed
| - build websocket 2.17
+- 

https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/3f38a28f9229e51d12d85b68724b7bcabeab7398/variant/compilers,4.08,websocket-lwt-unix.2.17

@mseri
Copy link
Member

mseri commented Sep 17, 2024

Looks fine now, thanks

@mseri mseri merged commit ad69387 into ocaml:master Sep 17, 2024
2 of 3 checks passed
@mseri
Copy link
Member

mseri commented Sep 17, 2024

@vbmithr please make these fixes upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants