Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forecast_hours is int only if reading a ATCF file that has OFCL along with CARQ #99

Open
SorooshMani-NOAA opened this issue Apr 29, 2024 · 0 comments
Assignees

Comments

@SorooshMani-NOAA
Copy link
Collaborator

See:

def unfiltered_data(self, dataframe: DataFrame):
# fill missing values of MRD and MSLP in the OFCL advisory
if "OFCL" in self.advisories:
tracks = separate_tracks(dataframe)
if all(adv in tracks for adv in ["OFCL", "CARQ"]):
tracks = correct_ofcl_based_on_carq_n_hollandb(tracks)
dataframe = combine_tracks(tracks)

The separate_tracks call changes the type from object to int64, but if the condition is not satisfied (i.e. OFCL and CARQ are not in the file) then the dataframes with modified forecast_hours type is ignored.

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant