Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PdrDashboard] Post v0.5 improvements #1559

Open
10 of 11 tasks
KatunaNorbert opened this issue Aug 28, 2024 · 3 comments
Open
10 of 11 tasks

[PdrDashboard] Post v0.5 improvements #1559

KatunaNorbert opened this issue Aug 28, 2024 · 3 comments
Labels
Type: Enhancement New feature or request

Comments

@KatunaNorbert
Copy link
Member

KatunaNorbert commented Aug 28, 2024

TODOs / DoD

  • #1560 - Norbert Improvements around the queries to have less and reuse data between pages.
    ex: use the same function to get all predictoors related data before the app starts in one place instead of using 1 method for home page predictoors table(payouts_stats) and Predictoors page table (predictoor_payouts_stats). The 2 table should have the same data source
  • #1571 - Norbert Display available lake date period at the top of the page and allow date period selection by button click
  • #1577 - Mustafa Switch from payouts to bronze_predictions which are incrementally updated
  • #1572 - Mustafa Add more columns to home page feeds table: Avg Accuracy, Sales and fix column sorting for both tables from home page
  • #1648 - Norbert Rename “Net income” to “Profit” because it can have negative values
  • Add “Profit” metric to predictoors page
  • #1645 - Norbert Tx costs on the home page look to be broken, it is the same value or very small variations between time periods(1D, 1W, 1M)
  • #1648 - Norbert Feeds page modal, rename ‘Predictions’ -> ’Nr of Predictions’
  • On Feds page Sales column explain what DF(data farming) and WS(web socket) sales mean. This could be done either by a tooltip, or inside the column header name etc
  • #1648 - Norbert Display the data period end date time, so if there are multiple update withing a day we know at what time the last update occurred. We could also display how often we update the data( rn it happens hours, and an indicator for this is seconds_between_parquet_export from the ppss file)
  • Upgrade dash testing. See dependencies.md for the full context. [Dependencies/Pdr Dashboard ToDos] Upgrade dash[testing] #1647
@KatunaNorbert KatunaNorbert added the Type: Enhancement New feature or request label Aug 28, 2024
@kdetry
Copy link
Contributor

kdetry commented Sep 3, 2024

Switch from payouts to bronze_predictions which are incrementally updated

Do we need it? The current queries rely on the payouts and are well tested.

@KatunaNorbert
Copy link
Member Author

Do we need it? The current queries rely on the payouts and are well tested.

If we want to have more accurate/up to date data then yes.
Right now we relay on certain calculations only on payout data and that could be outdated(User has to claim), for example there were cases where people were only calling the payout for right predictions( on this case, we also have to also look to predictions and consider those where there was no payout as loss or wrong ).

@kdetry
Copy link
Contributor

kdetry commented Sep 3, 2024

I am okay with this explanation, so I look at it, I am going to create a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants