Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

allow JSX and TSX commands #93

Open
swyxio opened this issue Nov 18, 2019 · 0 comments
Open

allow JSX and TSX commands #93

swyxio opened this issue Nov 18, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@swyxio
Copy link

swyxio commented Nov 18, 2019 •
edited
Loading

currently the command discovery rule here:

config/src/plugin.ts

Line 155 in d84a238

'**/*.+(js|ts)',
only matches .js and .ts files. However, .tsx files are also valid typescript. As react-ink becomes a thing, we should enable that too.

Maybe just add another regex for *x files? happy to PR this if y'all like it
@RasPhilCo RasPhilCo added enhancement New feature or request good first issue Good for newcomers labels Jun 8, 2020
@wittjosiah wittjosiah mentioned this issue Jul 22, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow jsx/tsx commands
2 participants
@RasPhilCo @swyxio