Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hook fails silently on yarn add during update of plugins #77

Merged
merged 2 commits into from
Jun 17, 2020
Merged

fix: hook fails silently on yarn add during update of plugins #77

merged 2 commits into from
Jun 17, 2020

Conversation

ArchangelX360
Copy link
Contributor

@ArchangelX360 ArchangelX360 commented Aug 5, 2019

Fixes #76

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #77 into master will decrease coverage by 58.48%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #77       +/-   ##
==========================================
- Coverage   58.48%   0.00%   -58.49%     
==========================================
  Files           9       5        -4     
  Lines         383      95      -288     
  Branches       67      17       -50     
==========================================
- Hits          224       0      -224     
+ Misses        118      95       -23     
+ Partials       41       0       -41     
Impacted Files Coverage Δ
src/hooks/update.ts 0.00% <0.00%> (ø)
src/commands/plugins/install.ts 0.00% <0.00%> (-83.34%) ⬇️
src/commands/plugins/update.ts 0.00% <0.00%> (-61.54%) ⬇️
src/commands/plugins/link.ts 0.00% <0.00%> (-61.12%) ⬇️
src/yarn.ts 0.00% <0.00%> (-47.77%) ⬇️
src/plugins.ts
src/commands/plugins/uninstall.ts
src/util.ts
src/commands/plugins/index.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809ab43...b3317e2. Read the comment docs.

src/hooks/update.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

@RasPhilCo RasPhilCo merged commit fcaffd9 into oclif:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update hook fails silently on yarn add errors
2 participants