feat: use version details from core #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@#W-12647786@
@W-12647786@
@W-12647786@
peternhale
requested review from
mdonnalley and
cristiand391
and removed request for
mdonnalley
src/commands/version.ts
Outdated
| @@ -22,43 +16,30 @@ export default class Version extends Command { | |||
| }), | |||
| } | |||
|
|
|||
| async run(): Promise<VersionDetail> { | |||
| async run(): Promise<Partial<VersionDetail>> { | |||
There was a problem hiding this comment.
Is this Partial needed? I see VersionDetail has pluginVersions as an optional prop.
There was a problem hiding this comment.
I'll try to remove it.
cristiand391
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-12647786@