Suggestion: follow the user's npmrc config by default #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
reviewed
Sep 4, 2024
src/hooks/init/check-update.ts
Outdated
| registry = config.npmRegistry ?? 'https://registry.npmjs.org', | ||
| timeoutInDays = 60, | ||
| registry = config.npmRegistry ?? getRegistryUrl(scope), // Use custom registry or fallback to 1) registry set for the scope, 2) default registry in the npmrc, or 3) the default registry | ||
| timeoutInDays = 7, |
There was a problem hiding this comment.
why change the default timeoutInDays?
There was a problem hiding this comment.
Fair question as it's not really relevant to this change in general, but this felt like a much more reasonable default for most tools. It's configurable so not a big deal but two months is a long time to wait (by default) to notify users of a new version.
|
This issue has been linked to a new work item: W-16659727 |
mdonnalley
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks up the registry url and authorization details from the npmrc file if they are not included in the config. Hardcoding registries and tokens in the config is not desirable if it can be avoided. Also drops tokens from logs / files to reduce the risk of leaking.