-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pypy to CI #19
Comments
My https://github.com/oconnor663/blake3-py/runs/3115660174?check_suite_focus=true Could be a PyO3 bug here? Some sort of PyPy quirkiness? I'll need to dig into this. |
We are seeing errors in Github actions auto test with blake3 py 0.2.0 |
I'm able to reproduce this error locally in a pypy3 virtualenv. I'll start here:
|
I've filed numpy/numpy#19536 related to the issue above. It doesn't appear to be blake3-specific. Not yet clear whether this explains other errors. |
Now I doubt the Numpy issue is related. If I add this extremely simple test, it sometimes passes (all 100k iterations) and sometimes fails (after a variable number of iterations, usually ~200): def test_simple():
expected = "04e0bb39f30b1a3feb89f536c93be15055482df748674b00d26e5a75777702e9"
for i in range(100_000):
print(i)
assert blake3(b"foo").hexdigest() == expected The failures look like this:
Something very fishy is going on with memory here. |
I've narrowed this down to what I believe is a different bug in PyO3: PyO3/pyo3#1736 |
After PyO3/maturin#596 ships.That fix has shipped.The text was updated successfully, but these errors were encountered: