Platform_SetWindowPos/Platform_SetWindowSize called continously in the viewport branch

[marius-luca-87]

Revision: 2515413
Date: 22-Nov-18 16:29:18

imgui.cpp after line 7850 "// Apply Position and Size (from ImGui to Platform/Renderer back-ends)"

    if (!viewport->PlatformRequestMove)
        g.PlatformIO.Platform_SetWindowPos(viewport, viewport->Pos);
    if (!viewport->PlatformRequestResize)
        g.PlatformIO.Platform_SetWindowSize(viewport, viewport->Size);

There seems to be a typo in the "platform request move/size"condition leading to continuous calls.

[ocornut]

It is currently intentional that we call those functions every frame, currently it doesn't seem to be problematic cost wise. The back-end can freely compare last known position.

[marius-luca-87]

Thanks for the info. I was unsure if this is something that needs to be handled on the backend side.

[ocornut]

I think I'll actually add a cache to compare too on imgui side now. I was hesitant because we may run into bugs, but if that's the case I'd rather run into them on imgui side.