Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS window title appears truncated #5975

Closed
eleriaqueen opened this issue Dec 10, 2022 · 2 comments
Closed

OS window title appears truncated #5975

eleriaqueen opened this issue Dec 10, 2022 · 2 comments
Labels
backends

Comments

@eleriaqueen
Copy link

Version/Branch of Dear ImGui:

Version: 91b356c
Branch: master

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_dx10 imgui_impl_win32
Compiler: GCC 12.2.0 i686-w64-mingw32
Operating System: Win10 Version 10.0.19044 Build 19044

My Issue/Question:

OS Window title appears truncated, should display string "Dear ImGui DirectX10 Example" but only displays "D".

Screenshots/Video

Capture021-bug

**Standalone, minimal, complete and verifiable example:

Use one of the imgui examples.
@ocornut
Copy link
Owner

ocornut commented Dec 12, 2022

Seems the same as #5961, there’s possibly an action we can do to, I gusss compile-settings may affect the Examples.

@ocornut ocornut mentioned this issue Jan 24, 2023
Closed
ocornut added a commit that referenced this issue Jan 24, 2023
@ocornut
Examples: Win32: Fixed examples using RegisterClassW() since 1.89 to …
98928b3 
…also call DefWindowProcW(). (#5725, #5961, #5975)
@ocornut
Copy link
Owner

ocornut commented Jan 24, 2023 •
edited
Loading

The changes done for #5725 (a229a7f and 0a7054c) are breaking examples apps when compiling without /D UNICODE

Fixed with fe0a24f by @markreidvfx

@ocornut ocornut closed this as completed Jan 24, 2023
ocornut pushed a commit that referenced this issue Jan 24, 2023
@markreidvfx @ocornut
Examples: Win32: Fixed examples using RegisterClassW() since 1.89 to …
fe0a24f 
…also call DefWindowProcW(). (#5725, #5961, #5975)

Fixes the window title from being truncated on calls to Platform_SetWindowTitle. Stops the WM_SETTEXT message that happens when calling setWindowTextW from being interpreted as ascii.
kjblanchard pushed a commit to kjblanchard/imgui that referenced this issue May 5, 2023
@markreidvfx @kjblanchard
Examples: Win32: Fixed examples using RegisterClassW() since 1.89 to …
fdd56f1 
…also call DefWindowProcW(). (ocornut#5725, ocornut#5961, ocornut#5975)

Fixes the window title from being truncated on calls to Platform_SetWindowTitle. Stops the WM_SETTEXT message that happens when calling setWindowTextW from being interpreted as ascii.
ocornut added a commit that referenced this issue Jun 13, 2023
@ocornut
Examples: Win32+OpenGL3: Fixed not calling DefWindowProcW() as with o…
3cc9d20 
…ther Win32 examples. (#6516, #5725, #5961, #5975)

Amend fe0a24f
@v-ein v-ein mentioned this issue Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backends
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eleriaqueen @ocornut