Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the GLFW3 version, entering text using an IME sends the "enter pressed" event prematurely #962

Closed
bluebear94 opened this issue Jan 2, 2017 · 4 comments

Comments

@bluebear94
Copy link

Most IMEs recognise pressing the Enter key as an instruction to finalise the input, but the GLFW3 backend sends the "enter pressed" event after any text input event. If the focus was previously on a textbox, the focus will be lost before any characters are entered.

In addition, it might be useful to ignore any Enter key presses that are used to confirm IME inputs, though I'm unsure how that would be done.

@ocornut
Copy link
Owner

ocornut commented Jan 2, 2017

I think this is a bug in GLFW3 which as far as I know was patched in 3.2 (I submitted the fix).
Which version of GLFW3 are you using?
glfw/glfw#651 (comment)
glfw/glfw#41 (comment)

@bluebear94
Copy link
Author

bluebear94 commented Jan 2, 2017

Upgraded from 3.1.2 to 3.3 and I still seem to get the bug.

(This is on Ubuntu 16.10 so the Win32 fix doesn't work here.)

@bluebear94
Copy link
Author

bluebear94 commented Jan 2, 2017

Maybe this PR and this commit are relevant?

You'll probably have to prepackage the test version of GLFW, though.

@ocornut
Copy link
Owner

ocornut commented Aug 8, 2022

I have confirmed that recent version of GLFW have this fixed (not sure exactly when it was fixed).

(We have still bundling in old windows binaries in examples/ because I have no idea of pushing more binaries to the repo)

@ocornut ocornut closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants