Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan Example #549

Merged
merged 4 commits into from
Apr 3, 2016
Merged

Vulkan Example #549

merged 4 commits into from
Apr 3, 2016

Conversation

Loftilus
Copy link
Contributor

@Loftilus Loftilus commented Mar 9, 2016

  • This example needs an update version of GLFW.
  • It currently uses the Vulkan headers from the GLFW repo. We can maybe put that in the libs folder?
  • To keep the code compact i decided to not properly setup Vulkan in main. I don't know if this will be an issue.

}
{
vkDestroySemaphore(g_Device, g_Semaphore[g_FrameIndex], g_Allocator);
VkSemaphoreCreateInfo info = {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need to delete and recreate the semaphores.

@ocornut
Copy link
Owner

ocornut commented Mar 9, 2016

Thanks. Will look at it when I have time.
Also see #531 "Add Vulkan rendering backend example" and https://github.com/tambry/ImGuiVulkanRenderer

@fire
Copy link

fire commented Apr 3, 2016

There is still interest in this. Hopefully it can be merged soon.

@ocornut
Copy link
Owner

ocornut commented Apr 3, 2016

You can probably merge them locally yourself and use the code already, nothing stops you from doing that :)

This looks mostly good but still needs some cleanup, if a PR comes not following the style-syntax-coding convention of other examples very precisely, my heuristic tells me that it's coming with other issues.

So as I understand the two shaders are built from source into SPV using the shell script and only the SPV is needed to run the example, not the shader sources?
This would probably need a readme to explain that flow, and a makefile. I'll look into it eventually.

@ocornut ocornut added this to the v1.48 milestone Apr 3, 2016
@ocornut ocornut merged commit 1394616 into ocornut:master Apr 3, 2016
@ocornut
Copy link
Owner

ocornut commented Apr 3, 2016

Merged (applied coding style changes but haven't changed the actual behavior apart from a few minor changes applied to other examples since this one was forked).

The situation with building examples is a total mess and we should aim to provide more organized build scripts eventually (perhaps using genie).

ocornut added a commit that referenced this pull request Jul 30, 2016
…les (#323)

Missing support Vulkan (#549), Apple (#575, #247), SDL (#58, #356),
Allegro, Marmalade (#368, #375)
ocornut added a commit that referenced this pull request Sep 18, 2017
…les (#323)

Missing support Vulkan (#549), Apple (#575, #247), SDL (#58, #356),
Allegro, Marmalade (#368, #375)
@ocornut ocornut added the vulkan label Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants